test(engine): add regression test for enum tag with definition refs#239
Merged
test(engine): add regression test for enum tag with definition refs#239
Conversation
BUG #6: Tagged alternation used wrong $tag when branches reference named definitions. The fix is already in master - this adds the regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression test for BUG #6: Tagged alternation used wrong
$tagwhen branches reference named definitions.The fix is already in master. This PR adds the regression test to prevent future regressions.
The Bug
When a definition name (e.g.,
Second) is interned before a branch label (e.g.,First), the enum member indices would mismatch because:Test Case
With input
42, the output should be{"$tag": "First", ...}(not"Second").